fix: stabilize builds, tests, and lint across all stacks
Complete stabilization pass bringing all 3 stacks to green:
Frontend (apps/web/):
- Fix TypeScript nullability in useSeason.ts, useTimeOfDay.ts hooks
- Disable no-undef in ESLint config (TypeScript handles it; JSX misidentified)
- Rename 306 story imports from @storybook/react to @storybook/react-vite
- Fix conditional hook call in useMediaQuery.ts useIsTablet
- Move useQuery to top of LoginPage.tsx component
- Remove useless try/catch in GearFormModal.tsx
- Fix stale closure in ResetPasswordPage.tsx handleChange
- Make Storybook decorators (withRouter, withQueryClient, withToast, withAudio)
no-ops since global StorybookDecorator already provides these — prevents
nested Router / duplicate provider crashes in vitest-browser
- Fix nested MemoryRouter in 3 page stories (TrackDetail, PlaylistDetail, UserProfile)
- Update i18n initialization in test setup (await init before changeLanguage)
- Update ~30 test assertions from English to French to match i18n translations
- Update test assertions to match SUMI V3 design changes (shadow vs border)
- Fix remaining story type errors (PlayerError, PlaylistBatchActions,
TrackFilters, VirtualizedChatMessages)
Backend (veza-backend-api/):
- Fix response_test.go RespondWithAppError signature (2 args, not 3)
- Fix TestErrorContractAuthEndpoints expected error codes
(ErrCodeUnauthorized vs ErrCodeInvalidCredentials)
- Fix TestTrackHandler_GetTrackLikes_Success missing auth middleware setup
- Fix TestPlaybackAnalyticsService_GetTrackStats k-anonymity threshold
(needs 5 unique users, not 1)
- Replace NOW() PostgreSQL function with time.Now() parameter in marketplace
service for SQLite test compatibility
- Add missing AutoMigrate entries in marketplace_test.go
(ProductImage, ProductPreview, ProductLicense, ProductReview)
Results:
- Frontend TypeCheck: 617 errors -> 0 errors
- Frontend ESLint: 349 errors -> 0 errors
- Frontend Vitest: 196 failing tests -> 1 skipped (3396/3397 passing)
- Backend go vet: 1 error -> 0 errors
- Backend tests: 5 failing -> all 13 packages passing
- Rust: 150/150 tests passing (unchanged)
- Storybook audit: 0 errors across 1244 stories
Triage report: docs/TRIAGE_REPORT.md
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-04-05 14:48:07 +00:00
|
|
|
import type { Meta, StoryObj } from '@storybook/react-vite';
|
2026-02-05 11:17:50 +00:00
|
|
|
import React from 'react';
|
2026-02-03 08:56:11 +00:00
|
|
|
import { ErrorBoundary } from './ErrorBoundary';
|
|
|
|
|
|
|
|
|
|
// Component that throws an error for testing
|
|
|
|
|
const ErrorThrower = ({ shouldThrow }: { shouldThrow?: boolean }) => {
|
|
|
|
|
if (shouldThrow) {
|
|
|
|
|
throw new Error('This is a test error for demonstrating ErrorBoundary');
|
|
|
|
|
}
|
|
|
|
|
return <div className="p-4 bg-green-100 text-green-800 rounded">Content rendered successfully!</div>;
|
|
|
|
|
};
|
|
|
|
|
|
|
|
|
|
const meta: Meta<typeof ErrorBoundary> = {
|
2026-02-05 12:21:54 +00:00
|
|
|
title: 'Docs/Failures/ErrorBoundary',
|
2026-02-03 08:56:11 +00:00
|
|
|
component: ErrorBoundary,
|
|
|
|
|
parameters: {
|
|
|
|
|
layout: 'fullscreen',
|
|
|
|
|
chromatic: { disableSnapshot: true },
|
|
|
|
|
},
|
|
|
|
|
tags: ['autodocs'],
|
|
|
|
|
};
|
|
|
|
|
|
|
|
|
|
export default meta;
|
|
|
|
|
type Story = StoryObj<typeof ErrorBoundary>;
|
|
|
|
|
|
|
|
|
|
export const NoError: Story = {
|
|
|
|
|
render: () => (
|
|
|
|
|
<ErrorBoundary>
|
|
|
|
|
<ErrorThrower shouldThrow={false} />
|
|
|
|
|
</ErrorBoundary>
|
|
|
|
|
),
|
|
|
|
|
};
|
|
|
|
|
|
2026-02-05 11:17:50 +00:00
|
|
|
// Helper to silence console.error during expected error tests
|
|
|
|
|
const ConsoleSilencer = ({ children }: { children: React.ReactNode }) => {
|
|
|
|
|
React.useEffect(() => {
|
|
|
|
|
const originalError = console.error;
|
|
|
|
|
console.error = (...args) => {
|
|
|
|
|
const msg = args[0]?.toString() || '';
|
|
|
|
|
// Suppress the specific test error and React's error boundary noise
|
|
|
|
|
if (msg.includes('This is a test error') || msg.includes('The above error occurred')) {
|
|
|
|
|
return;
|
|
|
|
|
}
|
|
|
|
|
originalError(...args);
|
|
|
|
|
};
|
|
|
|
|
return () => {
|
|
|
|
|
console.error = originalError;
|
|
|
|
|
};
|
|
|
|
|
}, []);
|
|
|
|
|
return <>{children}</>;
|
|
|
|
|
};
|
|
|
|
|
|
2026-02-03 08:56:11 +00:00
|
|
|
export const WithError: Story = {
|
2026-02-05 11:17:50 +00:00
|
|
|
parameters: { storybookAudit: { expectConsoleErrors: true } },
|
2026-02-03 08:56:11 +00:00
|
|
|
render: () => (
|
2026-02-05 11:17:50 +00:00
|
|
|
<ConsoleSilencer>
|
|
|
|
|
<ErrorBoundary>
|
|
|
|
|
<ErrorThrower shouldThrow={true} />
|
|
|
|
|
</ErrorBoundary>
|
|
|
|
|
</ConsoleSilencer>
|
2026-02-03 08:56:11 +00:00
|
|
|
),
|
|
|
|
|
};
|
|
|
|
|
|
|
|
|
|
export const WithCustomFallback: Story = {
|
2026-02-05 11:17:50 +00:00
|
|
|
parameters: { storybookAudit: { expectConsoleErrors: true } },
|
2026-02-03 08:56:11 +00:00
|
|
|
render: () => (
|
2026-02-05 11:17:50 +00:00
|
|
|
<ConsoleSilencer>
|
|
|
|
|
<ErrorBoundary
|
|
|
|
|
fallback={
|
|
|
|
|
<div className="p-8 text-center bg-amber-100 text-amber-800 rounded-lg">
|
|
|
|
|
<h2 className="text-xl font-bold mb-2">Custom Fallback</h2>
|
|
|
|
|
<p>Something went wrong, but we have a custom fallback UI.</p>
|
|
|
|
|
</div>
|
|
|
|
|
}
|
|
|
|
|
>
|
|
|
|
|
<ErrorThrower shouldThrow={true} />
|
|
|
|
|
</ErrorBoundary>
|
|
|
|
|
</ConsoleSilencer>
|
2026-02-03 08:56:11 +00:00
|
|
|
),
|
|
|
|
|
};
|