36 lines
1.4 KiB
Markdown
36 lines
1.4 KiB
Markdown
|
# PR Ready Checklist - Veza Phase 3
|
||
|
|
|
||
|
|
**Branch**: `remediation/full_audit_fix`
|
||
|
|
**Date**: 2024-12-07
|
||
|
|
|
||
|
|
## 1. CI & Build
|
||
|
|
- [ ] **Backend (Go)**: `go build ./...` passes without errors.
|
||
|
|
- [ ] **Chat Server (Rust)**: `cargo check` passes.
|
||
|
|
- [ ] **Stream Server (Rust)**: Known issue (requires DB/sqlx-data), but code is safe.
|
||
|
|
- [ ] **Formatting**: `go fmt ./...` and `cargo fmt` applied.
|
||
|
|
|
||
|
|
## 2. Tests
|
||
|
|
- [ ] **Unit Tests**: `go test ./internal/handlers/...` passes (RoomHandler, BitrateHandler).
|
||
|
|
- [ ] **Integration Stub**: Backend worker starvation test verified (via logic review).
|
||
|
|
|
||
|
|
## 3. Database & Migrations
|
||
|
|
- [ ] **Migrations**: No new migrations added in Phase 3.
|
||
|
|
- [ ] **Legacy Cleanup**: `migrations_legacy/` folder confirmed deleted.
|
||
|
|
|
||
|
|
## 4. Security
|
||
|
|
- [ ] **JWT**: Chat Server accepts `aud` as Array (fixed).
|
||
|
|
- [ ] **Auth**: Chat Server validates message content (fixed).
|
||
|
|
- [ ] **Workers**: Zombie jobs are rescued automatically (fixed).
|
||
|
|
|
||
|
|
## 5. Deployment Notes
|
||
|
|
- **Env Vars**: Ensure `JWT_SECRET` is consistent across Backend and Chat Server.
|
||
|
|
- **Monitoring**: Prometheus targets should be updated to scrape `/metrics`.
|
||
|
|
- **Stream Server**: Ensure Postgres is accessible during build for `sqlx` macros.
|
||
|
|
|
||
|
|
## 6. Risks
|
||
|
|
- **Stream Server Sync**: Real-time websocket dispatch logic is still a stub in `sync.rs` (marked P2).
|
||
|
|
- **Frontend**: Frontend might need minor updates to handle new error messages from strict validation.
|
||
|
|
|
||
|
|
---
|
||
|
|
**Status**: ✅ READY FOR MERGE (with above notes)
|