diff --git a/README.md b/README.md index 437803754..b4e7482ea 100644 --- a/README.md +++ b/README.md @@ -63,6 +63,10 @@ See `make/config.mk` for COMPOSE_PROD and deployment docs. - **Badge** : CI status above. Set `SLACK_WEBHOOK_URL` (Incoming Webhook) in repo secrets to receive Slack notifications on failure. +### Disabled workflows + +- **Storybook** (`chromatic.yml.disabled`, `storybook-audit.yml.disabled`, `visual-regression.yml.disabled`): deferred until MSW is wired up for `/api/v1/auth/me` and `/api/v1/logs/frontend`, which currently causes ~1 400 network errors in the Storybook build. The npm scripts (`storybook`, `build-storybook`) still work locally for one-off component inspection. To reactivate in CI, fix the MSW handlers and rename the three files back to `.yml`. + ## Documentation - **[Developer Onboarding](docs/ONBOARDING.md)** — Setup, architecture, conventions, troubleshooting diff --git a/apps/web/src/types/v2-v3-types.ts b/apps/web/src/types/domain.ts similarity index 95% rename from apps/web/src/types/v2-v3-types.ts rename to apps/web/src/types/domain.ts index c7cc6923b..1e4f3836d 100644 --- a/apps/web/src/types/v2-v3-types.ts +++ b/apps/web/src/types/domain.ts @@ -1,7 +1,7 @@ -/** - * Types additionnels de veza_frontend_web_v2 et veza_frontend_web_v3 - * Merged into apps/web for compatibility - */ +// UI / domain types (marketplace, social, gear, education, chat, files, +// analytics, moderation). These are not derived from OpenAPI — they describe +// shapes used by frontend features that aren't round-tripped to the backend +// as-is. Split by concern when any single feature starts owning enough of them. import { Track } from './api'; import { Product, ProductLicense, Review } from './marketplace'; diff --git a/apps/web/src/types/index.ts b/apps/web/src/types/index.ts index 18d46d815..d829f4b10 100644 --- a/apps/web/src/types/index.ts +++ b/apps/web/src/types/index.ts @@ -155,5 +155,5 @@ export interface ChatStats { rooms_active?: number; } -// Export additional types from v2/v3 -export * from './v2-v3-types'; +// UI / domain types (marketplace, social, gear, education, chat, files, ...) +export * from './domain'; diff --git a/veza-backend-api/internal/services/geoip_service.go b/veza-backend-api/internal/services/geoip_service.go index fc773dd78..6ad5a2500 100644 --- a/veza-backend-api/internal/services/geoip_service.go +++ b/veza-backend-api/internal/services/geoip_service.go @@ -66,18 +66,12 @@ func (s *GeoIPService) Lookup(ip string) (country, city string) { ipStr = strings.TrimPrefix(ipStr, "::ffff:") } - // TODO: Integrate MaxMind GeoLite2-City reader - // When GEOIP_DB_PATH is set to a valid .mmdb file, use: - // db, _ := maxminddb.Open(s.dbPath) - // var record struct { - // Country struct { ISOCode string `maxminddb:"iso_code"` } `maxminddb:"country"` - // City struct { Names map[string]string `maxminddb:"names"` } `maxminddb:"city"` - // } - // db.Lookup(parsed, &record) - // country = record.Country.ISOCode - // city = record.City.Names["en"] - // - // For now, return empty strings (geolocation column populated when MaxMind DB is installed) + // GeoIP resolution is deferred to v1.1.0. + // Implementing it requires: MaxMind license key, GeoLite2-City.mmdb download + // pipeline, automatic DB refresh job, and the oschwald/maxminddb-golang + // dependency. Out of scope for v1.0.4 (cleanup release). Until then, Lookup + // returns empty strings and the geolocation column stays NULL — this is a + // best-effort feature, not a hard requirement of any caller. return "", "" }