Commit graph

4 commits

Author SHA1 Message Date
senke
12f873bdb8 fix(husky): pre-commit cd recursion + lint-grep false positive
Two bugs in .husky/pre-commit made lint+typecheck+tests silently no-op:

1. cd recursion: `cd apps/web && ...` repeated 4× sequentially.
   After the 1st cd the CWD is apps/web, so `cd apps/web` again tries
   to enter apps/web/apps/web and errors out. Fix: wrap each step in
   a subshell `(cd apps/web && ...)` so the cd is scoped.

2. Lint grep false positive: `grep -q "error"` matched the ESLint
   summary line "(0 errors, K warnings)" — blocking commits even
   when lint was clean. Fix: `grep -qE "\([1-9][0-9]* error"` —
   matches only the summary with N>=1 errors.

With (1) alone, the hook would block any commit because of bug (2).
Both fixes land together to keep the hook usable.

Before: 3/4 steps no-op'd, and the 4th (lint) would have always
blocked if anything had ever triggered it.
After: all 4 steps run, and only actual errors block.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-04-20 20:20:40 +02:00
senke
be06ce90f8 implicit: implement Implicit 10.3 - add optional test check to pre-commit hook
- Added optional test check to pre-commit hook
- Runs unit tests only (fast, not E2E)
- Can be skipped with SKIP_TESTS=1 environment variable
- Blocks commits with failing tests
- Provides helpful error messages and tips
- Keeps pre-commit hook fast by only running unit tests
2026-01-16 14:18:41 +01:00
senke
9a0e1c4680 implicit: implement Implicit 9.2, 10.1, 10.2 - env validation and pre-commit hooks
- Implicit 9.2: Verified env validation already implemented (Zod schema with clear errors)
- Implicit 10.1: Added type checking to pre-commit hook (blocks on errors, allows warnings)
- Implicit 10.2: Added linting to pre-commit hook (blocks on errors, allows warnings)
- Pre-commit hook now runs: type generation, type checking, linting
- Prevents commits with TypeScript or linting errors
- Provides helpful error messages and tips
- Note: Pre-existing TypeScript errors in codebase will block commits until fixed
2026-01-16 13:04:49 +01:00
senke
b8cad69e3a api-contracts: add type generation to pre-commit hook
- Install husky as dev dependency
- Create pre-commit hook to run type generation script
- Ensures types are always up-to-date with backend API before commit
- Hook runs from apps/web directory to execute generate-types.sh
2026-01-15 17:00:30 +01:00