Commit graph

901 commits

Author SHA1 Message Date
senke
d4e9cd7175 api-contracts: add validation error alerting for high failure rates
- Created ValidationAlerting class to monitor validation metrics
- Alerts when failure rate exceeds threshold (default 5%)
- Periodic checks every 5 minutes (configurable)
- Cooldown period (15 min) to prevent alert spam
- Minimum validations required (10) before alerting
- Structured alert logging with full metrics context
- Automatically starts in production (can be disabled via env var)
- Alerts sent to backend logging and Sentry
- Action 1.2.2.4 complete - validation alerting now active for monitoring
2026-01-15 17:23:01 +01:00
senke
41bbcff116 api-contracts: add validation error metrics tracking
- Created ValidationMetricsTracker class to track validation metrics
- Tracks total, successful, and failed validations
- Calculates failure rate percentage
- Tracks failures by normalized endpoint patterns
- Records last failure and success timestamps
- Integrated into both validation points (wrapped and direct formats)
- Exported singleton for metrics access and monitoring
- Action 1.2.2.3 complete - validation metrics now tracked for monitoring
2026-01-15 17:21:41 +01:00
senke
94e369797d api-contracts: add production error logging for validation failures
- Enhanced validation error logging with production monitoring context
- Added error_type field for easy filtering in monitoring systems
- Added timestamp and schema_provided flag for correlation
- Logs automatically sent to backend endpoint and Sentry in production
- Structured JSON format for easy aggregation and alerting
- Action 1.2.2.2 complete - validation failures now fully logged for production monitoring
2026-01-15 17:19:17 +01:00
senke
efa2a90a50 api-contracts: enhance response validation for all responses with schemas
- Enhanced response validation logging (wrapped and direct formats)
- Changed validation failures from warn to error level for better visibility
- Added structured error details (path, message, code, received, expected)
- Added response data preview for debugging
- Added success logging in debug mode
- Maintains graceful degradation (continues with unvalidated data) to avoid breaking app
- Action 1.2.2.1 complete - validation now comprehensive for all responses with schemas
2026-01-15 17:18:02 +01:00
senke
ebeb9f83d6 api-contracts: complete type cleanup audit and clarify obsolete types
- Action 1.1.3.10: Clarified that Track/User/ApiError are NOT obsolete
  * ApiError already imported from schemas (not in api.ts)
  * Track and User are necessary extended types with UI-specific fields
  * Cannot be deleted without breaking functionality
- Action 1.1.3.11: Audited all type files for obsolete content
  * No empty or redundant files found
  * All type files serve a purpose (dto.ts, v2-v3-types.ts, backend-types.ts, api.ts)
  * Future migration can replace DTOs with generated types (separate task)
- Both actions complete - no cleanup needed at this time
2026-01-15 17:16:47 +01:00
senke
7302cce5bb api-contracts: mark pre-commit hook task as complete
- Pre-commit hook already exists and is configured correctly
- Hook runs type generation script before each commit
- Renumbered duplicate Action 1.1.3.13 to 1.1.3.15 for clarity
- Action 1.1.3.15 complete - no changes needed
2026-01-15 17:15:46 +01:00
senke
4b24f230a7 api-contracts: complete duplicate property analysis for type extensions
- Analyzed all extended types (User, Track) for duplicate properties
- No true duplicates found - all re-declarations serve a purpose:
  * Type narrowing (making optional fields required)
  * Type overrides (backward compatibility, type safety)
  * UI-specific extensions (aliases, computed fields)
- Action 1.1.3.14 complete - no properties to remove
2026-01-15 17:15:04 +01:00
senke
b44542b0bf api-contracts: update feature-specific auth types to use generated types
- Replace RefreshResponse with VezaBackendApiInternalDtoTokenResponse
- Replace ResendVerificationRequest with VezaBackendApiInternalDtoResendVerificationRequest
- Keep AuthResponse as is (uses extended User/AuthTokens)
- Keep form data types (frontend-specific)
- Tracks types already updated, roles/chat/settings kept as is
2026-01-15 17:13:43 +01:00
senke
48382c5194 api-contracts: update barrel exports to document generated type usage
- Add documentation noting User, Track extend generated types
- Export generated types directly for advanced use cases
- Update comments to reflect ApiError location (schemas)
- All existing imports continue to work via barrel exports
2026-01-15 17:11:23 +01:00
senke
716d397f2c api-contracts: replace User interface with generated type base
- Update User type in types/api.ts to extend VezaBackendApiInternalModelsUser
- Preserve UI-specific computed fields (avatar_url, stats, roles, status, etc.)
- Make required fields actually required (id, username, email, role, etc.)
- All existing imports continue to work via barrel exports
- No User-specific TypeScript errors introduced
2026-01-15 17:09:14 +01:00
senke
f1ea34562b api-contracts: replace Track interface with generated type base
- Update Track type in types/api.ts to extend VezaBackendApiInternalModelsTrack
- Update Track type in features/tracks/types/track.ts to extend generated type
- Preserve UI-specific computed fields (coverUrl, plays, likes, etc.)
- Support backward compatibility for duration (number|string)
- All existing imports continue to work without changes
- No Track-specific TypeScript errors introduced
2026-01-15 17:07:50 +01:00
senke
7df3a03e46 api-contracts: replace ApiError interface with Zod-inferred type
- Replace manual ApiError interface with Zod-inferred type from apiSchemas
- Update all imports (15+ files) to use ApiError from @/schemas/apiSchemas
- Remove ApiError interface from types/api.ts
- Update ApiResponse to import ApiError from schemas
- All TypeScript checks pass for ApiError-related code
2026-01-15 17:03:35 +01:00
senke
b8cad69e3a api-contracts: add type generation to pre-commit hook
- Install husky as dev dependency
- Create pre-commit hook to run type generation script
- Ensures types are always up-to-date with backend API before commit
- Hook runs from apps/web directory to execute generate-types.sh
2026-01-15 17:00:30 +01:00
senke
64f62635a5 api-versioning: add X-API-Deprecated header and frontend deprecation warning
- Backend: Add X-API-Deprecated header alongside existing X-API-Version-Deprecated
- Frontend: Show deprecation warning toast when deprecated API version detected
- Warning shown only once per session to avoid spam
- Includes sunset date in warning message if available
2026-01-15 16:56:21 +01:00
senke
daada38da8 state-ownership: replace all useAuthStore().user with useUser() hook
- Migrated all hooks: useAuth, useChat, useLogin
- Migrated all components: Header, ProfileForm, FollowButton, LikeButton, PlaylistFollowButton, ChatMessage, ChatMessages, CommentThread, CommentSection, PlaylistList, ChatSidebar, SettingsPage, DashboardPage
- Updated storeSelectors.ts useAuthUser() to use React Query
- All production code now uses useUser() hook instead of Zustand store
- Action 4.1.1.3 and 4.1.1.4 complete
2026-01-14 01:45:42 +01:00
senke
9ceaebd14a state-ownership: audit all files using useAuthStore().user
Found 24 files using user from authStore:
- 18 components (Header, DashboardPage, Chat components, etc.)
- 4 hooks (useAuth, useChat, useLogin)
- 2 utilities (stateHydration, storeSelectors docs)

Created comprehensive audit document with migration strategy.

Action 4.1.1.2 complete
2026-01-14 01:40:42 +01:00
senke
4bc6c52a45 state-ownership: mark middleware removal actions as complete
Actions 4.1.2.5, 4.1.2.6, and 4.1.2.7 were already completed in Action 4.1.2.4:
- undoRedo middleware removed (no domain data to track)
- stateNormalization utilities removed (React Query handles normalization)
- stateMiddleware wrapper removed (no domain data to track)

All middlewares were removed when domain data was removed from library store.

Actions 4.1.2.5, 4.1.2.6, 4.1.2.7 complete
2026-01-14 01:39:53 +01:00
senke
f7a87afd49 state-ownership: remove domain data from library store
- Remove items, favorites, pagination, isLoading, error from LibraryState
- Remove fetchItems, fetchFavorites, uploadFile, toggleFavorite, deleteItem, clearItems, setLoading, setError from LibraryActions
- Remove undoRedo and stateMiddleware wrappers (no domain data to track)
- Update useLibraryActions() to use React Query for all domain data actions
- Store now only contains filters (UI state)
- Update useLibraryItemsNormalized() and useLibraryFavoritesNormalized() to return empty state (deprecated)
- Update useLibraryPagination() to return both camelCase and snake_case for compatibility

Action 4.1.2.4 complete
2026-01-14 01:39:23 +01:00
senke
76d95ecfb4 incus deployement fully implemented, Makefile updated and make fmt ran 2026-01-13 19:47:57 +01:00
senke
2743064511 state-ownership: mark Action 4.1.2.8 as complete
All components using library store domain data have been migrated:
- DashboardPage components use selectors from storeSelectors.ts
- Selectors have been migrated to React Query hooks (Action 4.1.2.3.3)
- No direct access to store domain data found
- Components automatically migrated via selector abstraction layer

Action 4.1.2.8 complete
2026-01-12 13:45:11 +01:00
senke
2b74cac84f state-ownership: update storeSelectors.ts to use React Query hooks
- Replace useLibraryItems() with React Query hook
- Replace useLibraryFavorites() with React Query hook
- Replace useLibraryPagination() to extract from React Query response
- Replace useLibraryStatus() to use React Query status
- Update useLibraryActions() to use queryClient.refetchQueries()
- Maintain same interface for backward compatibility
- Migrates DashboardPage components automatically

Action 4.1.2.3.3 complete
2026-01-12 13:37:02 +01:00
senke
95565f4d96 state-ownership: audit components using library store domain data - found 2 DashboardPage components and storeSelectors utility 2026-01-11 18:21:08 +01:00
senke
8903dfcdae state-ownership: create React Query hooks for library items (useLibraryItems, useLibraryFavorites) 2026-01-11 18:19:52 +01:00
senke
44bdd3c42a state-ownership: mark field categorization complete (done in audit) 2026-01-11 18:18:56 +01:00
senke
45686bee1e state-ownership: audit library store domain data - identified 3 domain fields and 3 UI state fields 2026-01-11 18:18:45 +01:00
senke
18df75c906 state-ownership: audit track queries React Query usage - only comments/likes use React Query 2026-01-11 18:18:15 +01:00
senke
ae4a516083 state-ownership: update STATE_SELECTORS.md with correct auth store import path 2026-01-11 18:17:45 +01:00
senke
aab5d169b0 state-ownership: mark stateCleanup audit actions as complete (already deleted) 2026-01-11 18:17:10 +01:00
senke
b5a1720fc8 state-ownership: update STATE_DEBUGGING.md to reflect current store structure (Action 4.6.1.7) 2026-01-11 18:04:42 +01:00
senke
2f7a30b97f state-ownership: remove obsolete state utilities (stateCleanup, stateVersioning, statePersistence) 2026-01-11 18:03:58 +01:00
senke
8721555b76 state-ownership: categorize state utilities as needed, redundant, or obsolete (Action 4.6.1.2) 2026-01-11 18:03:13 +01:00
senke
42ef9898b2 state-ownership: mark cartStore and playerStore migrations as not needed (Actions 4.5.1.7, 4.5.1.9) 2026-01-11 18:00:35 +01:00
senke
e07ac90c2a state-ownership: audit cartStore for domain data (Action 4.5.1.6) 2026-01-11 18:00:11 +01:00
senke
6df94cff81 state-ownership: mark store audit actions complete (4.5.1.6, 4.5.1.8, 4.5.1.10) 2026-01-11 17:58:31 +01:00
senke
f7870354cc state-ownership: list all state utility files (Action 4.6.1.1) 2026-01-11 17:58:05 +01:00
senke
e67e206130 state-ownership: verify stores/auth.ts is removed (Action 4.5.1.3) 2026-01-11 17:57:19 +01:00
senke
2c0b329481 state-ownership: categorize stores as UI state vs domain data (Action 4.5.1.2) 2026-01-11 17:56:45 +01:00
senke
08e9faacd4 state-ownership: list all Zustand stores (Action 4.5.1.1) 2026-01-11 17:56:31 +01:00
senke
eb6dce73ef state-ownership: audit all mutations for optimistic updates (Action 4.4.1.4) 2026-01-11 17:55:39 +01:00
senke
4c9bb1ac8f state-ownership: audit custom optimistic updates (Action 4.4.1.1) 2026-01-11 17:43:51 +01:00
senke
8b6b8afd6c state-ownership: create React Query hook for user (Action 4.1.1.1) 2026-01-11 17:43:07 +01:00
senke
243ab0518e error-propagation: integrate offline detection utility with error handler 2026-01-11 17:42:04 +01:00
senke
3b01f74637 error-propagation: add offline detection utility 2026-01-11 17:41:37 +01:00
senke
28766b1646 error-propagation: enhance network error detection to distinguish timeout, connection refused, and offline 2026-01-11 17:41:08 +01:00
senke
bfa02332e6 error-propagation: fix retry handlers and mark Action 3.4.1.3 complete 2026-01-11 17:40:21 +01:00
senke
d1303abbe3 error-propagation: implement retry for failed mutations (remaining handlers) 2026-01-11 17:39:51 +01:00
senke
3625618584 error-propagation: implement retry for failed mutations (ShareDialog, CommentSection) 2026-01-11 17:38:54 +01:00
senke
364d0c9cd0 error-propagation: implement retry for failed mutations (MarketplaceHome, RolesPage, SettingsPage) 2026-01-11 17:38:15 +01:00
senke
ed5c37b15a error-propagation: implement retry for failed mutations (AccountSettings) 2026-01-11 17:37:04 +01:00
senke
396df6b7e9 error-propagation: implement retry for failed mutations (Cart) 2026-01-11 17:36:33 +01:00