Commit graph

87 commits

Author SHA1 Message Date
senke
7594c94f38 docs: audit all interactive elements (Action 8.2.1.2)
- Created comprehensive audit document: apps/web/docs/INTERACTIVE_ELEMENTS_AUDIT.md
- Identified 10 categories of interactive elements
- Found 500+ interactive elements across codebase
- Documented patterns: good, needs improvement, missing
- Prioritized areas for hover/focus state improvements
- Task 8.2.1.2 complete
2026-01-16 00:35:01 +01:00
senke
02f84fa1f0 docs: determine primary upload button location (Action 8.1.1.2)
- Primary: Dashboard FAB (global, always accessible, most prominent)
- Secondary: LibraryPage header button (contextual, always visible)
- To remove: LibraryPage empty state buttons (redundant)
- To remove: LibraryManager buttons (component unused - legacy code)
- Updated audit document with decision rationale
- Task 8.1.1.2 complete
2026-01-16 00:32:05 +01:00
senke
4988b97af0 docs: audit all upload buttons (Action 8.1.1.1)
- Found 6 upload button instances across 3 components
- Created comprehensive audit document: apps/web/docs/UPLOAD_BUTTONS_AUDIT.md
- Identified duplicates: empty state buttons redundant with header buttons
- Primary candidates: Dashboard FAB and LibraryPage header button
- Recommendations for removal documented
- Task 8.1.1.1 complete
2026-01-16 00:31:34 +01:00
senke
320468fb1c spacing: create comprehensive SPACING_GUIDE.md
- Created complete spacing system guide in apps/web/docs/SPACING_GUIDE.md
- Documented numeric and semantic spacing scales with full value tables
- Included usage guidelines, best practices, and common patterns
- Added migration guide for replacing arbitrary values
- Documented ESLint enforcement and related documentation
- Task 7.2.1.7 complete
2026-01-16 00:22:30 +01:00
senke
390ed09d2f spacing: audit all spacing classes usage
- Audited 2,761 spacing class instances across 366 files
- Categorized by type: gap (1,314), padding (1,041), padding x/y (784), space-between (611), margin (217)
- Identified inconsistencies: all numeric values, no semantic classes, arbitrary values
- Created comprehensive audit report with recommendations
- Task 7.2.1.2 complete
2026-01-15 23:57:33 +01:00
senke
420f5d5489 typography: standardize paragraph text sizes
- Standardized 9 paragraphs without explicit sizes
- Added text-sm to secondary/description text (7 instances)
- Added text-base to body text (2 instances)
- Established standard: text-base for body, text-sm for secondary
- Verified 490 paragraphs across 207 files follow type scale
- Created standardization plan document
- Task 7.1.2.4 complete
2026-01-15 23:55:35 +01:00
senke
f0e16e37d8 typography: standardize h2-h6 heading elements
- Standardized h2 elements: 19 instances from text-3xl/text-xl to text-2xl
- Standardized h3 elements: 4 instances from text-2xl to text-xl
- Established consistent hierarchy: h1(text-3xl), h2(text-2xl), h3(text-xl)
- Preserved special cases: demo pages, responsive patterns, stat value displays
- Created standardization plan document
- Task 7.1.2.3 complete
2026-01-15 23:54:05 +01:00
senke
8ff2195e66 visual-hierarchy: complete audit of all h1 elements
- Audited 55 h1 elements across 52 files
- Documented size distribution: text-3xl (26), text-2xl (16), text-4xl (10), etc.
- Identified inconsistencies: 6 different sizes used for h1 elements
- Found 11+ files with text-2xl h1 that should be text-3xl for consistency
- Documented responsive patterns and special cases
- Provided recommendations for standardization
- Created comprehensive audit report in apps/web/docs/H1_ELEMENTS_AUDIT_REPORT.md
- Action 7.1.2.1 complete
2026-01-15 21:26:39 +01:00
senke
3ab8bdf07d visual-hierarchy: update typography replacement guide with complete analysis
- Documented all remaining arbitrary text sizes (9px, 10px, 11px instances)
- Noted that 99.8% of text already uses scale correctly
- Documented edge cases for design review
- Guide now complete with full inventory
2026-01-15 21:20:51 +01:00
senke
8b553860c3 visual-hierarchy: replace arbitrary text sizes with scale classes
- Replaced text-[9px] with text-xs in WishlistView.tsx
- Replaced font-size: 11px with var(--text-xs) in badge-avatar.css
- Analyzed all text sizing: 1,891 usages already use scale correctly
- Documented edge cases: SVG chart text and intentional 10px sizes kept as-is
- Created TYPOGRAPHY_REPLACEMENT_GUIDE.md with full analysis
- 99.8% of text already uses scale - only 2 safe replacements made
- Action 7.1.1.4 complete
2026-01-15 21:20:06 +01:00
senke
192d5a1855 visual-hierarchy: complete typography audit of all text size classes
- Audited 1,891 text size class usages across 342 files
- Documented usage distribution: text-sm (870), text-xs (596), text-2xl (130), etc.
- Identified top 10 files with highest usage
- Analyzed usage patterns by component type (pages, forms, cards, navigation)
- Identified inconsistencies in heading hierarchies and body text sizes
- Provided recommendations for standardization
- Created comprehensive audit report in apps/web/docs/TYPOGRAPHY_AUDIT_REPORT.md
- Action 7.1.1.3 complete
2026-01-15 21:17:59 +01:00
senke
ccc3bfd105 scalability: confirm bundle optimization not needed
- Verified all bundle size metrics exceed industry standards
- Initial bundle: ~246KB (excellent, < 300KB standard)
- Total JS: 764KB (good, < 1MB standard)
- Page chunks: 4.5-8.5KB (excellent, < 50KB standard)
- Code splitting: Excellent (55 chunks, proper vendor isolation)
- All routes lazy-loaded with small chunks
- Vendor chunks properly isolated
- CSS properly split
- Conclusion: Bundle sizes are already optimal, no optimization required
- Action 6.2.1.8 complete (no changes needed)
2026-01-15 21:00:04 +01:00
senke
04ba2f9bb2 scalability: measure and document bundle sizes after code splitting
- Created comprehensive bundle size report (BUNDLE_SIZE_REPORT.md)
- Total JavaScript: 764KB across 55 chunks
- Total CSS: 66KB
- Initial load: ~246KB (excellent)
- Average page chunk: 4.5-8.5KB (excellent lazy loading)
- Vendor chunks properly isolated (React core: 209KB)
- All routes lazy-loaded with small chunks
- Bundle sizes meet industry standards
- Action 6.2.1.7 complete
2026-01-15 20:58:52 +01:00
senke
e65995c6b9 scalability: audit heavy components for code splitting
- Created HEAVY_COMPONENTS_AUDIT.md documenting all heavy components
- Identified already lazy-loaded components: EmojiPicker, ImageCropper, Toaster
- Verified chart components are lightweight (custom SVG, no heavy libraries)
- Confirmed heavy libraries already in vendor chunks
- Documented feature chunks already configured
- Identified potential optimizations (@dnd-kit, dompurify) - low priority
- Conclusion: Most heavy components already optimized
- Action 6.2.1.3 complete
2026-01-15 20:50:51 +01:00
senke
239021c046 state-ownership: categorize state utilities as needed, redundant, or obsolete (Action 4.6.1.2) 2026-01-11 18:03:13 +01:00
senke
1446b034d5 state-ownership: audit cartStore for domain data (Action 4.5.1.6) 2026-01-11 18:00:11 +01:00
senke
5d87bd6a71 state-ownership: list all state utility files (Action 4.6.1.1) 2026-01-11 17:58:05 +01:00
senke
9d94ca378c state-ownership: verify stores/auth.ts is removed (Action 4.5.1.3) 2026-01-11 17:57:19 +01:00
senke
ae47a2fbb2 state-ownership: list all Zustand stores (Action 4.5.1.1) 2026-01-11 17:56:31 +01:00
senke
bb1f1adcb9 state-ownership: audit all mutations for optimistic updates (Action 4.4.1.4) 2026-01-11 17:55:39 +01:00
senke
506f694793 state-ownership: audit custom optimistic updates (Action 4.4.1.1) 2026-01-11 17:43:51 +01:00
senke
bef60625b9 error-propagation: audit all mutation error handlers 2026-01-11 17:33:30 +01:00
senke
b7cc9281ff error-propagation: audit existing ErrorBoundary usage 2026-01-11 17:31:41 +01:00
senke
674c7d9a9c error-propagation: audit all error display patterns across codebase 2026-01-11 17:00:58 +01:00
senke
fbae159dba data-flow: remove duplicate LibraryPagePremium.tsx file
- Completed Action 2.2.1.3: Handled LibraryPage.tsx vs LibraryPagePremium.tsx duplication
- Updated LIBRARY_PAGE_AUDIT.md with file comparison
- Verified LibraryPage.tsx is active (imported via LazyLibrary in routing)
- Verified LibraryPagePremium.tsx is duplicate/unused (not imported anywhere)
- LibraryPagePremium.tsx is older version without debounce improvements
- Removed LibraryPagePremium.tsx - safe deletion, no references found
- Routing continues to use LibraryPage.tsx, no breakage
2026-01-11 16:51:47 +01:00
senke
2cf53900b2 data-flow: standardize debounce across all search inputs
- Completed Action 2.4.1.3: Audited and standardized search input debouncing
- Created SEARCH_DEBOUNCE_AUDIT.md documenting all search components
- Found 7 search components: 5 using useDebounce, 1 manual setTimeout, 1 manual search
- Standardized AddTrackToPlaylistModal to use useDebounce hook instead of manual setTimeout
- All automatic search inputs now use consistent debouncing (300-500ms delays)
- MessageSearch uses manual search (intentional, no debounce needed)
2026-01-11 16:51:23 +01:00
senke
00bc329fa8 data-flow: verify cache invalidation and size limits already implemented
- Completed Actions 2.5.1.9 and 2.5.1.10: Verified features already exist
- Created CACHE_FEATURES_VERIFICATION.md documenting verification
- Action 2.5.1.9: Cache invalidation already implemented via invalidateStateAfterMutation in response interceptor (line 493)
- Action 2.5.1.10: Cache size limits already implemented (maxSize=100, FIFO eviction)
- Both features working correctly, no changes needed
2026-01-11 16:45:17 +01:00
senke
ac9c822809 data-flow: audit offline queue utility
- Completed Action 2.5.1.3: Audited offlineQueue utility
- Created OFFLINE_QUEUE_AUDIT.md with complete analysis
- Verified core functionality: queue management, priority system, persistence, retry logic
- Verified integration: Error interceptor queues network errors (line 999-1007)
- Verified UI integration: OfflineIndicator displays queue size
- Documented queue configuration: 100 request limit, 3 retries, 24h expiry
- Identified potential issues: FormData serialization, token refresh on replay
- Provided recommendations for testing and improvements
2026-01-11 16:44:53 +01:00
senke
ff080ad791 data-flow: audit response cache utility
- Completed Action 2.5.1.2: Audited responseCache utility
- Created RESPONSE_CACHE_AUDIT.md with complete analysis
- Verified core functionality: GET-only caching, Cache-Control support, ETag/Last-Modified
- Documented cache configuration (5min TTL, 100 entry limit, FIFO eviction)
- Identified potential issues: Limited usage, no automatic invalidation after mutations
- Noted cache only used via deduplicatedApiClient, not main apiClient
- Provided recommendations for integration and improvements
2026-01-11 16:44:28 +01:00
senke
cfd24d0327 data-flow: audit request deduplication utility
- Completed Action 2.5.1.1: Audited requestDeduplication utility
- Created REQUEST_DEDUPLICATION_AUDIT.md with complete analysis
- Verified core functionality: promise sharing, key generation, cleanup
- Documented usage patterns via deduplicatedApiClient
- Identified potential issues: FormData handling, unbounded cache size
- Noted utility may not be actively used (needs verification)
- Provided recommendations for improvements and testing
2026-01-11 16:44:05 +01:00
senke
dce80481c4 data-flow: verify LibraryPage.tsx.old is not imported
- Completed Action 2.2.1.4: Verified LibraryPage.tsx.old has no imports
- Created LIBRARY_PAGE_AUDIT.md documenting file status
- Confirmed LibraryPage.tsx.old is safe to delete (no references)
- Identified LibraryPagePremium.tsx as duplicate/unused (needs Action 2.2.1.3)
- Active LibraryPage.tsx is imported via LazyComponent in routing
- Ready for Action 2.2.1.5: Remove LibraryPage.tsx.old
2026-01-11 16:43:37 +01:00
senke
bfa3ac9cec api-contracts: audit all API endpoints for request schemas
- Completed Action 1.2.1.3: Comprehensive endpoint-to-schema audit
- Created ENDPOINT_SCHEMA_AUDIT.md with complete mapping
- Audited 56 endpoints: 9 have schemas (36%), 16 missing (64%)
- Identified HIGH priority: 2FA schemas (3 endpoints)
- Identified MEDIUM priority: Upload chunking, batch ops, analytics, webhooks (6 endpoints)
- Identified LOW priority: Marketplace, logging, verification (4 endpoints)
- Ready for Action 1.2.1.4: Add missing request validation schemas
2026-01-11 16:38:15 +01:00
senke
57a5e214b2 api-contracts: document Zod schema generation strategy
- Completed Action 1.2.1.2: Documented strategy for generating Zod schemas
- Created ZOD_SCHEMA_GENERATION_PLAN.md with hybrid approach
- Identified challenge: Swagger 2.0 format limits automated generation
- Strategy: Keep existing manual schemas, generate missing schemas manually
- Identified 15+ missing request schemas (analytics, marketplace, webhooks, 2FA, upload chunking)
- Recommended: Short-term manual creation, medium-term generation script, long-term OpenAPI 3.0 migration
2026-01-11 16:37:55 +01:00
senke
f52aac2117 api-contracts: audit feature-specific type files
- Completed Action 1.1.3.12: Audited all feature type files
- Created FEATURE_TYPES_AUDIT.md documenting 5 feature type files
- Identified tracks, auth, chat, roles, and settings type files
- Documented migration needs for each file
- Estimated 10-15 types need replacement with generated types
2026-01-11 16:35:02 +01:00
senke
525fd1e074 api-contracts: audit type files for duplication with generated types
- Completed Actions 1.1.3.6-1.1.3.8: Audited dto.ts, v2-v3-types.ts, backend-types.ts
- Created TYPE_FILES_AUDIT.md documenting findings
- dto.ts: 8 DTOs can be replaced, 2 may need to stay (ValidationError)
- v2-v3-types.ts: Most types are UI-specific, 1-3 may be replaceable
- backend-types.ts: Small file, 0-2 types may be replaceable
- Documented migration paths for each file
2026-01-11 16:34:24 +01:00
senke
38db75218f api-contracts: audit existing Zod schemas and identify gaps
- Completed Action 1.2.1.1: Audited existing Zod schemas
- Created ZOD_SCHEMA_AUDIT.md documenting coverage
- Found 20+ existing schemas covering core types
- Identified 15+ missing request schemas for specialized endpoints
- Documented gaps in analytics, marketplace, webhooks, 2FA, and upload endpoints
2026-01-11 16:32:40 +01:00
senke
4c2113f56c api-contracts: create type migration plan documenting all files using manual types
- Completed Action 1.1.3.1: Types already generated (marked complete)
- Completed Action 1.1.3.2: Created TYPE_MIGRATION_PLAN.md
- Documented 36+ files requiring migration
- Listed type mappings (Track → VezaBackendApiInternalModelsTrack, etc.)
- Defined 4-phase migration strategy
- Includes validation and rollback plans
2026-01-11 16:32:11 +01:00