veza/veza-backend-api/internal
senke 376d9adc44 ci: retire legacy backend-ci.yml, centralize Docker probe in SkipIfNoIntegration
Two changes in one commit because they address the same root cause: the
Forgejo self-hosted runner doesn't expose a Docker socket, and the legacy
backend-ci.yml workflow both required Docker for its integration tests
AND enforced a 75% coverage gate that the codebase has never met (actual
~33%). The consolidated Veza CI workflow (ci.yml) already covers the
same Go build / test / govulncheck surface and is now green — there's
no reason to keep the legacy duplicate red in parallel.

1. .github/workflows/backend-ci.yml → backend-ci.yml.disabled

   Renamed, not deleted. Reactivation path:
     - Raise real coverage closer to 75%, OR lower the threshold in the
       workflow file to a realistic value (30–40%)
     - Provide Docker socket access on the runner OR gate the
       integration job on a docker-in-docker service
     - `git mv` it back to .yml

   This finishes the CI consolidation that started in 2c6217554
   ("ci: consolidate rust-ci + stream-ci into ci.yml Rust job").
   backend-ci.yml was the last un-consolidated workflow and its two
   failure modes (coverage gate + missing Docker) made it permanently
   red without measuring anything the consolidated ci.yml doesn't
   already check.

2. testutils.SkipIfNoIntegration: add a runtime Docker probe

   Before: only honored `-short` and VEZA_SKIP_INTEGRATION=1. Tests
   calling GetTestRedisClient / GetTestContainerDB on a host without
   Docker would get past the skip check and then fail inside
   testcontainers.GenericContainer with "rootless Docker not found".
   This is exactly what happened to the J4 TestCleanRedisKeys_Integration
   on the Forgejo runner (run 105).

   After: added a memoized `dockerAvailable()` helper that probes
   testcontainers.NewDockerProvider() once per test process. If the
   probe fails, all tests calling SkipIfNoIntegration skip cleanly
   instead of panicking. Result: J4 worker test skips on Forgejo,
   still runs (and passes) on any host with Docker.

   The probe is centralized so any existing or future integration test
   that calls SkipIfNoIntegration gets this behavior for free — no need
   to sprinkle inline docker checks.

Verification (local, Docker available):
  go build ./...                                                     OK
  go test ./internal/workers/ -run TestCleanRedisKeys_Integration    PASS (3.26s)
  SkipIfNoIntegration logic audited — no_short / no_env_var path
  still runs the Docker probe, Docker-unavailable path calls t.Skip
  with a clear message.

Expected CI impact:
  - Veza CI / Backend (Go): already green, should stay green
  - Backend API CI: no longer runs (workflow disabled)
  - All other statuses unchanged
2026-04-15 16:12:45 +02:00
..
api ci(cache): add save-always to persist cache on job failure 2026-04-14 18:01:40 +02:00
common v0.9.2 2026-03-05 19:27:34 +01:00
config style(backend): gofmt -w on 85 files (whitespace only) 2026-04-14 12:22:14 +02:00
core style(backend): gofmt -w on 85 files (whitespace only) 2026-04-14 12:22:14 +02:00
database v0.9.4 2026-03-05 23:03:43 +01:00
dto Phase 2 stabilisation: code mort, Modal→Dialog, feature flags, tests, router split, Rust legacy 2026-02-14 17:23:32 +01:00
elasticsearch style(backend): gofmt -w on 85 files (whitespace only) 2026-04-14 12:22:14 +02:00
email STABILISATION: phase 3–5 – API contract, tests & chat-server hardening 2025-12-06 17:21:59 +01:00
errors v0.9.8 2026-03-06 19:13:16 +01:00
eventbus feat: backend — config, handlers, services, logging, migration 2026-03-23 15:46:57 +01:00
features adding initial backend API (Go) 2025-12-03 20:29:37 +01:00
handlers refactor(backend): J3 — remove 3 deprecated unused handlers 2026-04-14 18:11:07 +02:00
infrastructure v0.9.4 2026-03-05 23:03:43 +01:00
integration style(backend): gofmt -w on 85 files (whitespace only) 2026-04-14 12:22:14 +02:00
interfaces adding initial backend API (Go) 2025-12-03 20:29:37 +01:00
jobs fix(v0.12.6.1): remediate remaining 15 MEDIUM + LOW pentest findings 2026-03-12 06:13:38 +01:00
logging style(backend): gofmt -w on 85 files (whitespace only) 2026-04-14 12:22:14 +02:00
metrics v0.9.4 2026-03-05 23:03:43 +01:00
middleware style(backend): gofmt -w on 85 files (whitespace only) 2026-04-14 12:22:14 +02:00
models style(backend): gofmt -w on 85 files (whitespace only) 2026-04-14 12:22:14 +02:00
monitoring v0.9.4 2026-03-05 23:03:43 +01:00
pagination v0.9.8 2026-03-06 19:13:16 +01:00
recovery chore(v0.102): consolidate remaining changes — docs, frontend, backend 2026-02-20 13:02:12 +01:00
repositories fix(v0.12.6.1): remediate 2 CRITICAL + 10 HIGH + 1 MEDIUM pentest findings 2026-03-12 05:40:53 +01:00
repository fix(v0.12.6.1): update in-memory UserRepositoryImpl to accept context.Context 2026-03-12 05:47:47 +01:00
resilience chore: consolidate CI, E2E, backend and frontend updates 2026-02-17 16:43:21 +01:00
response fix: stabilize builds, tests, and lint across all stacks 2026-04-05 16:48:07 +02:00
security refactor(backend): replace 40 fmt.Printf calls with zap structured logging 2026-02-22 17:44:38 +01:00
services chore(cleanup): J5 — defer GeoIP, rename v2-v3-types, document Storybook kill 2026-04-15 12:43:57 +02:00
shutdown incus deployement fully implemented, Makefile updated and make fmt ran 2026-01-13 19:47:57 +01:00
testutils ci: retire legacy backend-ci.yml, centralize Docker probe in SkipIfNoIntegration 2026-04-15 16:12:45 +02:00
tracing incus deployement fully implemented, Makefile updated and make fmt ran 2026-01-13 19:47:57 +01:00
types feat(profile): add profile privacy toggle (B3) 2026-02-20 15:10:02 +01:00
upload [INT-015] int: Add file upload format standardization 2025-12-25 15:40:01 +01:00
utils fix(v0.12.6): apply all pentest remediations — 36 findings across 36 files 2026-03-14 00:44:46 +01:00
validators feat(v0.13.3): complete - Polish Sécurité Avancée 2026-03-13 10:09:01 +01:00
websocket style(backend): gofmt -w on 85 files (whitespace only) 2026-04-14 12:22:14 +02:00
workers fix(backend): J4 — GDPR-compliant hard delete with Redis and ES cleanup 2026-04-15 12:25:39 +02:00