3f326e8266
Some checks failed
Veza CI / Rust (Stream Server) (push) Successful in 4m22s
Security Scan / Secret Scanning (gitleaks) (push) Successful in 1m5s
Veza CI / Frontend (Web) (push) Failing after 17m19s
E2E Playwright / e2e (full) (push) Failing after 20m28s
Veza CI / Backend (Go) (push) Successful in 21m31s
Veza CI / Notify on failure (push) Successful in 4s
Three pre-existing infra issues surfaced by the Day 1→Day 3 push wave.
Each is independent — bundled here because the goal is "ci.yml + e2e.yml
green" before the v1.0.9 tag, and they're all small.
(1) gofmt — ci.yml golangci-lint v2 step
Five files were unformatted on main. Pre-existing (untouched by my
Item G work, but the formatter caught them now):
- internal/api/router.go
- internal/core/marketplace/reconcile_hyperswitch_test.go
- internal/models/user.go
- internal/monitoring/ledger_metrics.go
- internal/monitoring/ledger_metrics_test.go
Pure whitespace via `gofmt -w` — no behavior change.
(2) e2e silent-fail — playwright webServer port collision
The e2e workflow pre-starts the backend in step 9 ("Build + start
backend API") so it can fail-fast on a non-ok health check. But
playwright.config.ts had `reuseExistingServer: !process.env.CI` on
the backend webServer entry — meaning in CI Playwright tried to
spawn a SECOND backend on port 18080. The spawn collided with
EADDRINUSE and Playwright silently exited before printing any test
output. The artifact upload then warned "No files were found"
because tests/e2e/playwright-report/ never got written, and the job
ended in `Failure` for an unrelated reason (the artifact upload
step's GHESNotSupportedError).
Fix: backend `reuseExistingServer: true` always — workflow + dev
both pre-start backend on 18080. Vite stays `!CI` because the
workflow doesn't pre-start it. Comment in playwright.config.ts
documents the symptom so the next person debugging gets the
pointer immediately.
(3) orders.hyperswitch_payment_id missing in fresh DBs — migration 080
skip-branch + 099 ordering drift
Migration 080 (`add_payment_fields`) wraps its ALTERs in
"skip if orders doesn't exist". At authoring time orders existed
earlier in the migration sequence; that ordering has since shifted
(orders is now created at 099_z_create_orders.sql, AFTER 080).
Result: in any freshly-migrated DB (CI, fresh dev, future restore
drills) migration 080 takes the skip branch and the columns are
never added — even though the Order model and the marketplace code
rely on them.
Symptom: every CI run logs
pq: column "hyperswitch_payment_id" does not exist
from the periodic ledger_metrics worker. Order checkout would also
fail to persist payment_id at write time, breaking reconciliation.
Fix: append-only migration 987 with idempotent
`ADD COLUMN IF NOT EXISTS` + a partial index on the reconciliation
hot path. Production envs that did pick up 080 in the original
order are no-ops; fresh envs converge to the same end state.
Rollback in migrations/rollback/.
Verified locally:
$ cd veza-backend-api && go build ./... && VEZA_SKIP_INTEGRATION=1 \
go test -short -count=1 ./internal/...
(all green)
SKIP_TESTS=1: backend-only Go + Playwright config + SQL. Frontend
unit tests irrelevant to this commit.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
||
|---|---|---|
| .. | ||
| 23-visual-regression.spec.ts-snapshots | ||
| audit | ||
| fixtures | ||
| helpers | ||
| scripts | ||
| tests/e2e/audit/results/screenshots | ||
| 01-auth.spec.ts | ||
| 02-navigation.spec.ts | ||
| 03-player.spec.ts | ||
| 04-tracks.spec.ts | ||
| 05-playlists.spec.ts | ||
| 06-search-discover.spec.ts | ||
| 07-social.spec.ts | ||
| 08-marketplace.spec.ts | ||
| 09-chat-notifications-settings.spec.ts | ||
| 10-features.spec.ts | ||
| 11-accessibility-ethics.spec.ts | ||
| 12-api.spec.ts | ||
| 13-workflows.spec.ts | ||
| 14-edge-cases.spec.ts | ||
| 15-routes-coverage.spec.ts | ||
| 16-forms-validation.spec.ts | ||
| 17-modals-dialogs.spec.ts | ||
| 18-empty-states.spec.ts | ||
| 19-responsive.spec.ts | ||
| 20-network-errors.spec.ts | ||
| 21-error-boundary.spec.ts | ||
| 22-performance.spec.ts | ||
| 23-visual-regression.spec.ts | ||
| 24-cross-browser.spec.ts | ||
| 25-profile.spec.ts | ||
| 25-register-defer-jwt.spec.ts | ||
| 26-smoke.spec.ts | ||
| 26-verify-email-header.spec.ts | ||
| 27-chunked-upload-s3.spec.ts | ||
| 27-upload.spec.ts | ||
| 28-storybook.spec.ts | ||
| 29-chat-functional.spec.ts | ||
| 30-marketplace-checkout.spec.ts | ||
| 31-auth-sessions.spec.ts | ||
| 32-deep-pages.spec.ts | ||
| 33-visual-bugs.spec.ts | ||
| 34-workflows-empty.spec.ts | ||
| 35-register.spec.ts | ||
| 36-forgot-password.spec.ts | ||
| 37-reset-password.spec.ts | ||
| 38-user-profile.spec.ts | ||
| 39-feed.spec.ts | ||
| 40-library.spec.ts | ||
| 41-chat-deep.spec.ts | ||
| 42-player-deep.spec.ts | ||
| 43-upload-deep.spec.ts | ||
| 44-auth-deep.spec.ts | ||
| 45-playlists-deep.spec.ts | ||
| 46-search-discover-deep.spec.ts | ||
| 47-social-deep.spec.ts | ||
| 48-marketplace-deep.spec.ts | ||
| 49-notifications-settings-deep.spec.ts | ||
| COVERAGE_MAP.md | ||
| dashboard-audit.spec.ts | ||
| design-system.spec.ts | ||
| discover.spec.ts | ||
| global-setup.ts | ||
| global-teardown.ts | ||
| helpers.ts | ||
| launch-audit.spec.ts | ||
| login-audit.spec.ts | ||
| playlists-audit.spec.ts | ||
| playlists-detail-audit.spec.ts | ||
| playlists-edit-audit.spec.ts | ||
| playlists-favoris-audit.spec.ts | ||
| playlists-shared-token.spec.ts | ||
| playwright.config.ts | ||
| queue-audit.spec.ts | ||
| search-audit.spec.ts | ||
| SKIPPED_TESTS.md | ||
| tracks-detail-audit.spec.ts | ||
| verify-email-audit.spec.ts | ||
| VEZA_AUDIT_REPORT.md | ||