veza/apps/web/src/components/settings/security/SessionManagement.tsx
senke 12a78616df refactor(web): zero out @typescript-eslint/no-unused-vars (134 → 0)
Two-step cleanup of the no-unused-vars warning bucket :

1. Widened the rule's ignore patterns in eslint.config.js so the
   `_`-prefix convention works uniformly across all four contexts
   (function args, local vars, caught errors, destructured arrays).
   The argsIgnorePattern was already `^_` ; added varsIgnorePattern,
   caughtErrorsIgnorePattern, destructuredArrayIgnorePattern with
   the same `^_` regex. Knocked 17 warnings out instantly because the
   codebase had already adopted `_xxx` for unused locals and was
   waiting on this config change.

2. Fixed the remaining 117 cases across 99 files by pattern :
   * 26 catch-binding cases : `catch (e) {…}` → `catch {…}` (TS 4.0+
     optional binding, ES2019). Cleaner than `catch (_e)` for the
     dozen "swallow and toast" error handlers that don't read the
     error.
   * 58 unused imports removed (incl. one literal `electron`
     contextBridge import that crept in from a phantom port-attempt).
   * 28 destructure / assignment cases : prefixed with `_` where the
     name documents the contract (test fixtures, hook return tuples
     where one slot isn't used yet) ; deleted outright when the
     assignment had no side effect and no documentary value.
   * 3 function param cases : prefixed with `_`.
   * 2 self-recursive `requestAnimationFrame` blocks that were dead
     code (an interval-based alternative did the work) : deleted.

`tsc --noEmit` reports 0 errors after the changes. ESLint total
dropped from 1240 to 1108. Updated the baseline in
.github/workflows/ci.yml in the next commit.

Pattern decisions logged inline so future maintainers know that
`_`-prefix isn't slop — it's the documented, lint-aware way to mark
"intentionally unused" without having to remove the name.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-04-30 23:05:32 +02:00

138 lines
4.9 KiB
TypeScript

import React, { useState, useEffect } from 'react';
import { Card } from '../../ui/card';
import { Button } from '../../ui/button';
import { Smartphone, Monitor, Clock } from 'lucide-react';
import { useToast } from '../../../components/feedback/ToastProvider';
import { sessionService, Session } from '../../../services/sessionService';
import { logger } from '@/utils/logger';
export const SessionManagement: React.FC = () => {
const { addToast } = useToast();
const [sessions, setSessions] = useState<Session[]>([]);
const [loading, setLoading] = useState(true);
useEffect(() => {
loadSessions();
}, []);
const loadSessions = async () => {
try {
setLoading(true);
const res = await sessionService.getSessions();
setSessions(res.sessions);
} catch (error) {
logger.error('Error loading sessions', {
error: error instanceof Error ? error.message : String(error),
stack: error instanceof Error ? error.stack : undefined,
});
} finally {
setLoading(false);
}
};
const handleRevoke = async (id: string) => {
try {
await sessionService.revokeSession(id);
setSessions((prev) => prev.filter((s) => s.id !== id));
addToast('Session revoked successfully', 'success');
} catch {
addToast('Failed to revoke session', 'error');
}
};
const handleRevokeAll = async () => {
try {
await sessionService.logoutAll();
// Ideally reload or clear all except current, but for safety re-fetch
loadSessions();
addToast('All other sessions have been logged out', 'success');
} catch {
addToast('Failed to log out all devices', 'error');
}
};
if (loading)
return (
<div className="text-center p-4 text-muted-foreground">Loading sessions...</div>
);
return (
<Card variant="default">
<div className="flex justify-between items-center mb-6">
<div>
<h3 className="text-xl font-bold text-foreground">Active Sessions</h3>
<p className="text-sm text-muted-foreground">
Manage devices logged into your account.
</p>
</div>
<Button
variant="ghost"
className="text-destructive hover:bg-destructive/10 border-destructive/30"
onClick={handleRevokeAll}
>
Log Out All Other Devices
</Button>
</div>
<div className="space-y-4">
{sessions.map((session) => {
// Simple heuristics for icon since backend might not provide device type explicitly yet
const isMobile = session.user_agent.toLowerCase().includes('mobile');
return (
<div
key={session.id}
className="flex flex-col md:flex-row md:items-center justify-between p-4 bg-card rounded-xl shadow-[0_0_8px_rgba(26,26,30,0.05)] transition-colors"
>
<div className="flex items-start gap-4">
<div
className={`p-4 rounded-full ${session.is_current ? 'bg-primary/10 text-primary' : 'bg-muted text-muted-foreground'}`}
>
{isMobile ? (
<Smartphone className="w-6 h-6" />
) : (
<Monitor className="w-6 h-6" />
)}
</div>
<div>
<div className="flex items-center gap-2">
<h4 className="font-bold text-foreground text-sm">
{session.ip_address}
</h4>
{session.is_current && (
<span className="bg-success/10 text-success text-xs px-2 py-0.5 rounded border border-success/30 font-bold">
CURRENT DEVICE
</span>
)}
</div>
<p className="text-xs text-muted-foreground mt-1 truncate max-w-xs">
{session.user_agent}
</p>
<div className="flex items-center gap-4 mt-2 text-xs text-muted-foreground">
<span className="flex items-center gap-1">
<Clock className="w-3 h-3" /> Active:{' '}
{new Date(session.last_activity).toLocaleString()}
</span>
</div>
</div>
</div>
{!session.is_current && (
<Button
variant="ghost"
size="sm"
className="mt-4 md:mt-0 text-muted-foreground hover:text-foreground shadow-[0_0_8px_rgba(26,26,30,0.05)] hover:bg-muted"
onClick={() => handleRevoke(session.id)}
>
Revoke Access
</Button>
)}
</div>
);
})}
{sessions.length === 0 && (
<p className="text-center text-muted-foreground text-sm py-8">No active sessions found.</p>
)}
</div>
</Card>
);
};