No description
8a4681643c
Second feature-service migration after B3 (profileService → user). Replaces
raw apiClient calls in @/features/playlists/services/playlistService.ts
with the orval-generated functions from services/generated/playlist/playlist.ts.
All 19 public function signatures preserved — no callers touched.
Functions migrated (19):
- createPlaylist → postPlaylists
- getPlaylist → getPlaylistsId
- getPlaylistByShareToken → getPlaylistsSharedToken
- updatePlaylist → putPlaylistsId
- deletePlaylist → deletePlaylistsId
- importPlaylist → postPlaylistsImport
- getFavorisPlaylist → getPlaylistsFavoris
- listPlaylists → getPlaylists (orval)
- addCollaborator → postPlaylistsIdCollaborators
- removeCollaborator → deletePlaylistsIdCollaboratorsUserId
- updateCollaboratorPermission → putPlaylistsIdCollaboratorsUserId
- searchPlaylists → getPlaylistsSearch
- createShareLink → postPlaylistsIdShare
- reorderPlaylistTracks → putPlaylistsIdTracksReorder
- removeTrackFromPlaylist → deletePlaylistsIdTracksTrackId
- duplicatePlaylist → postPlaylistsIdDuplicate
- getPlaylistRecommendations → getPlaylistsRecommendations
- getCollaborators → getPlaylistsIdCollaborators
- addTrackToPlaylist → postPlaylistsIdTracks
Functions still on raw apiClient (endpoints lack swaggo annotations,
deferred v1.0.9):
- followPlaylist → POST /playlists/{id}/follow
- unfollowPlaylist → DELETE /playlists/{id}/follow
- getPlaylistFollowStatus → derives from getPlaylist (no dedicated endpoint)
Two helpers normalize envelope shapes returned by the backend:
- unwrapPayload<T>(raw) → strips `{ data: ... }` envelope when present.
- pickPlaylist(raw) → also unwraps `{ playlist: ... }` for single-resource
responses.
listPlaylists keeps its sortBy/sortOrder params in the public signature
for forward-compat, but the orval call drops them — the backend swaggo
annotation on GET /playlists (playlist_handler.go:230-242) declares only
page/limit/user_id, and the handler ignores any sort args silently. To
be revisited when the backend annotation is extended (v1.0.9).
Test file rewritten to mock the generated module
(@/services/generated/playlist/playlist) for all migrated functions.
The orval mocks delegate back to the existing apiClient mock so the 43
existing assertions on `expect(apiClient.X).toHaveBeenCalledWith(...)`
continue to pass without rewriting 800+ LOC of test bodies. Same shim
pattern as B3.
Consumer-side fix: PlaylistsView.tsx setPlaylists call cast to
`Playlist[]` (the component imports Playlist from `@/types`, while the
service exposes Playlist from `@/features/playlists/types` — they have
slightly divergent `tracks` shapes, an existing types/api drift to be
unified in B9).
Tests: 332/332 green (43 in playlistService.test.ts + 289 in adjacent
playlists tests). npm run typecheck: clean.
Bisectable: revert this commit → service returns to apiClient pattern,
PlaylistsView reverts to its untyped setPlaylists call. No interceptor
changes, no data-shape drift.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
||
|---|---|---|
| .github | ||
| .husky | ||
| .zap | ||
| apps/web | ||
| chat_exports | ||
| config | ||
| dev-environment | ||
| docker/haproxy | ||
| docs | ||
| docs-assets/mermaid | ||
| fixtures | ||
| full_veza_audit_data | ||
| home/senke/git/talas/veza/apps/web/src | ||
| infra | ||
| k8s | ||
| loadtests | ||
| make | ||
| packages/design-system | ||
| prompts | ||
| proto | ||
| scripts | ||
| sub_task_agents | ||
| test-reports/20251226-132633 | ||
| tests | ||
| tmt | ||
| tools | ||
| veza-backend-api | ||
| veza-common | ||
| veza-docs | ||
| veza-stream-server | ||
| .commitlintrc.json | ||
| .cursorrules | ||
| .editorconfig | ||
| .gitattributes | ||
| .gitignore | ||
| .gitleaks.toml | ||
| .lighthouserc.js | ||
| .lintstagedrc.json | ||
| .nvmrc | ||
| .pa11yci.json | ||
| .semgrepignore | ||
| AUDIT_REPORT.md | ||
| CHANGELOG.md | ||
| CLAUDE.md | ||
| CONTRIBUTING.md | ||
| docker-compose.dev.yml | ||
| docker-compose.env.example | ||
| docker-compose.override.yml.example | ||
| docker-compose.prod.yml | ||
| docker-compose.staging.yml | ||
| docker-compose.test.yml | ||
| docker-compose.yml | ||
| env.remote-r720.example | ||
| FUNCTIONAL_AUDIT.md | ||
| go.work | ||
| go.work.sum | ||
| help | ||
| Makefile | ||
| package-lock.json | ||
| package.json | ||
| README.md | ||
| RELEASE_NOTES_V1.md | ||
| run-audit.sh | ||
| rust-toolchain.toml | ||
| status.sh | ||
| turbo.json | ||
| Untitled | ||
| VERSION | ||
| VEZA_VERSIONS_ROADMAP.md | ||
Veza Monorepo
Version courante : v1.0.4 (cleanup + consolidation post-audit). Voir CHANGELOG.md et docs/PROJECT_STATE.md.
Project Structure
apps/web— Frontend React 18 + Vite 5 + TypeScript strict (source of truth for the UI)veza-backend-api— Main Go 1.25 API service (Gin, GORM, Postgres, Redis, RabbitMQ, Elasticsearch). Handles REST, WebSocket, and chat (chat server was merged into this service in v0.502).veza-stream-server— Rust streaming server (Axum 0.8, Tokio 1.35, Symphonia) — HLS, HTTP Range, WebSocket, gRPCveza-common— Shared Rust types and loggingpackages/design-system— Shared design tokens
See CLAUDE.md for the full architecture map.
Development Setup
Prerequisites: Node 20 (see .nvmrc), Go, Rust, Docker. Configure .env from .env.example.
# Verify environment
make doctor
./scripts/validate-env.sh development
# Install dependencies
make install-deps
# Option A — Backend in Docker + Web local
make dev
# Option B — All apps local with hot reload (infra from docker-compose.dev.yml)
make dev-full
# Option C — Infra only, then run services manually
docker compose -f docker-compose.dev.yml up -d
make dev-web # or make dev-backend-api, make dev-stream-server
See docs/ENV_VARIABLES.md for required variables. make build builds all services.
Quick Start
Frontend only
cd apps/web
npm install
npm run dev
Docker Production
Canonical production compose file: docker-compose.prod.yml
docker compose -f docker-compose.prod.yml up -d
See make/config.mk for COMPOSE_PROD and deployment docs.
CI/CD
- Badge : CI status above. Set
SLACK_WEBHOOK_URL(Incoming Webhook) in repo secrets to receive Slack notifications on failure.
Disabled workflows
- Storybook (
chromatic.yml.disabled,storybook-audit.yml.disabled,visual-regression.yml.disabled): deferred until MSW is wired up for/api/v1/auth/meand/api/v1/logs/frontend, which currently causes ~1 400 network errors in the Storybook build. The npm scripts (storybook,build-storybook) still work locally for one-off component inspection. To reactivate in CI, fix the MSW handlers and rename the three files back to.yml.
Documentation
- Developer Onboarding — Setup, architecture, conventions, troubleshooting
- Documentation index — Index complet de la documentation
- See
docs/for detailed architecture and development guides. Older audits and reports are archived indocs/archive/.