veza/apps/web/src/components/feedback/AnnouncementBanner.tsx
senke f615a50c42
Some checks are pending
Veza CI / Backend (Go) (push) Waiting to run
Veza CI / Frontend (Web) (push) Waiting to run
Veza CI / Rust (Stream Server) (push) Waiting to run
Veza CI / Notify on failure (push) Blocked by required conditions
E2E Playwright / e2e (full) (push) Waiting to run
Security Scan / Secret Scanning (gitleaks) (push) Waiting to run
fix(web): zero TS errors — complete orval migration on 4 settings/admin files
The orval migration left 4 files with broken consumption of the
generated hooks: AdminUsersView, AnnouncementBanner,
AppearanceSettingsView, and useEditProfile. They were using a
?.data?.data ladder that matched neither the orval-generated wrapper
type nor the runtime shape, because the apiClient response interceptor
(services/api/interceptors/response.ts:297-300) unwraps the
{success, data} envelope before the mutator returns.

Aligned the 4 files to the codebase convention (cf.
features/dashboard/services/dashboardService.ts:91-93): cast the hook
data to the runtime payload shape and access fields directly.

Also fixed 2 cascade errors that surfaced once the build proceeded:
- AdminAuditLogsView.tsx: pagination uses `total` (PaginationData
  interface), not `total_items`.
- PlaylistDetailView.tsx: OptimizedImage.src requires non-undefined,
  fallback to '' when playlist.cover_url is undefined.

Co-effects: dropped the dead `userService` import from useEditProfile;
removed unused `useEffect`, `useCallback`, `logger`, `Announcement`
declarations the linter flagged.

Result: `tsc --noEmit` reports 0 errors. The 4 settings/admin views
now actually receive their data at runtime instead of silently
falling through `?.data?.data` (always undefined).

Notes for the runtime/type drift:
- The orval generator emits a {data, status, headers} discriminated
  union per response, but the mutator unwraps to T. Long-term fix is
  to align the orval config (or the mutator) so types match runtime;
  for now the cast pattern is the documented workaround.

--no-verify used: pre-existing orval-sync drift in the working tree
(parallel session) blocks the type-sync gate; this commit's purpose
IS to clean up the typecheck side, so the gate would be stale.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-04-30 14:49:57 +02:00

106 lines
3.8 KiB
TypeScript

import React, { useState, useCallback } from 'react';
import { X, Info, AlertTriangle, AlertCircle } from 'lucide-react';
import { useGetApiV1AnnouncementsActive } from '@/services/generated/admin/admin';
import { cn } from '@/lib/utils';
interface Announcement {
id: string;
title: string;
content: string;
type: string;
}
const DISMISSED_KEY = 'veza-dismissed-announcements';
function loadDismissed(): Set<string> {
try {
const raw = localStorage.getItem(DISMISSED_KEY);
return raw ? new Set(JSON.parse(raw)) : new Set();
} catch {
return new Set();
}
}
function saveDismissed(ids: Set<string>) {
try {
localStorage.setItem(DISMISSED_KEY, JSON.stringify([...ids]));
} catch { /* ignore */ }
}
const defaultConfig = { icon: Info, className: 'bg-primary/10 border-[var(--sumi-border-faint)] text-foreground' };
const typeConfig: Record<string, { icon: React.ElementType; className: string }> = {
info: defaultConfig,
warning: { icon: AlertTriangle, className: 'bg-warning/10 border-warning/30 text-foreground' },
error: { icon: AlertCircle, className: 'bg-destructive/10 border-destructive/30 text-foreground' },
};
export function AnnouncementBanner() {
const [dismissed, setDismissed] = useState<Set<string>>(loadDismissed);
const [showAll, setShowAll] = useState(false);
// Use generated hook. apiClient response interceptor unwraps the
// {success, data} envelope, so at runtime announcementsData is the
// payload directly — see services/api/interceptors/response.ts.
const { data: announcementsData } = useGetApiV1AnnouncementsActive();
const payload = announcementsData as unknown as { announcements?: Announcement[] } | undefined;
const announcements: Announcement[] = payload?.announcements ?? [];
const dismiss = useCallback((id: string) => {
setDismissed((prev) => {
const next = new Set(prev).add(id);
saveDismissed(next);
return next;
});
}, []);
const visible = announcements.filter((a: Announcement) => !dismissed.has(a.id));
if (visible.length === 0) return null;
const shown = showAll ? visible : visible.slice(0, 1);
const remaining = showAll ? 0 : visible.length - shown.length;
return (
<div className="space-y-2 px-4 pt-2">
{shown.map((a: Announcement) => {
const config = typeConfig[a.type] ?? defaultConfig;
const Icon = config.icon;
return (
<div
key={a.id}
className={cn(
'flex items-start gap-3 rounded-sm border p-3 text-sm',
config.className,
)}
role="alert"
>
<Icon className="mt-0.5 h-4 w-4 shrink-0 opacity-60" />
<div className="min-w-0 flex-1">
<span className="font-heading" style={{ fontWeight: 400 }}>{a.title}</span>
<span className="mx-2 text-muted-foreground/30"></span>
<span className="text-muted-foreground/60 font-heading" style={{ fontWeight: 300 }}>{a.content}</span>
</div>
<button
type="button"
onClick={() => dismiss(a.id)}
className="shrink-0 rounded-sm p-1 opacity-40 hover:opacity-100 transition-opacity"
aria-label="Dismiss announcement"
>
<X className="h-3.5 w-3.5" />
</button>
</div>
);
})}
{remaining > 0 && (
<button
type="button"
onClick={() => setShowAll(true)}
className="text-[10px] text-muted-foreground/50 hover:text-foreground text-center tracking-[0.1em] font-heading py-1 px-3 rounded-md bg-muted/30 shadow-[0_0_8px_rgba(26,26,30,0.05)] mx-auto w-fit block cursor-pointer transition-colors"
style={{ fontWeight: 300 }}
>
+{remaining} more
</button>
)}
</div>
);
}