veza/apps
senke c488a4b8d6 refactor(web): migrate authService partial to orval (v1.0.8 B6)
Fourth feature-service migration after dashboard / profile / playlist /
track. Replaces 4 of 9 raw apiClient calls in
@/features/auth/services/authService.ts with orval-generated functions
from services/generated/auth/auth.ts.

Functions migrated (4):
- login                        → postAuthLogin
- logout                       → postAuthLogout (empty body)
- resendVerificationEmail      → postAuthResendVerification
- checkUsernameAvailability    → getAuthCheckUsername

Functions deliberately NOT migrated (5, deferred v1.0.9 — would need
backend annotation fixes or careful prod verification before changing
the wire shape on critical auth paths):

  - register     — backend DTO `register_request.go:8` declares
                   `json:"password_confirmation"` but the frontend
                   currently sends `password_confirm`. orval-typed body
                   would force the rename, which is the correct shape
                   per the swaggo spec but a behaviour change on a
                   critical path. Needs a separate validation pass
                   against staging before flipping.
  - refreshToken — same drift: backend DTO uses `refresh_token`,
                   frontend uses `refreshToken`. Identical risk profile.
  - requestPasswordReset / resetPassword — endpoints not yet annotated
                   in swaggo (no /auth/password/* paths in
                   openapi.yaml). Backend annotation extension required
                   first.
  - verifyEmail  — verb drift (frontend GET /auth/verify-email?token=
                   vs orval-generated POST). Coupled with the parked
                   FUNCTIONAL_AUDIT §4#7 query→header migration; both
                   should land together.

Test rewrite: orval module mocked to delegate back to the existing
apiClient mock. The 17 existing assertions on
`expect(apiClient.post).toHaveBeenCalledWith('/auth/...', ...)` keep
working without rewriting the test bodies, same shim pattern as B4 / B5.

Tests: 302/302 in features/auth/ green. npm run typecheck: clean.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-04-25 23:25:43 +02:00
..
web refactor(web): migrate authService partial to orval (v1.0.8 B6) 2026-04-25 23:25:43 +02:00