0e7097ed1b
First-attempt commit3a5c6e184only captured the .gitignore change; the pre-commit hook silently dropped the 343 staged moves/deletes during lint-staged's "no matching task" path. This commit re-applies the intended J1 content on top ofbec75f143(which was pushed in parallel). Uses --no-verify because: - J1 only touches .md/.json/.log/.png/binaries — zero code that would benefit from lint-staged, typecheck, or vitest - The hook demonstrated it corrupts pure-rename commits in this repo - Explicitly authorized by user for this one commit Changes (343 total: 169 deletions + 174 renames): Binaries purged (~167 MB): - veza-backend-api/{server,modern-server,encrypt_oauth_tokens,seed,seed-v2} Generated reports purged: - 9 apps/web/lint_report*.json (~32 MB) - 8 apps/web/tsc_*.{log,txt} + ts_*.log (TS error snapshots) - 3 apps/web/storybook_*.json (1375+ stored errors) - apps/web/{build_errors*,build_output,final_errors}.txt - 70 veza-backend-api/coverage*.out + coverage_groups/ (~4 MB) - 3 veza-backend-api/internal/handlers/*.bak Root cleanup: - 54 audit-*.png (visual regression baselines, ~11 MB) - 9 stale MVP-era scripts (Jan 27, hardcoded v0.101): start_{iteration,mvp,recovery}.sh, test_{mvp_endpoints,protected_endpoints,user_journey}.sh, validate_v0101.sh, verify_logs_setup.sh, gen_hash.py Session docs archived (not deleted — preserved under docs/archive/): - 78 apps/web/*.md → docs/archive/frontend-sessions-2026/ - 43 veza-backend-api/*.md → docs/archive/backend-sessions-2026/ - 53 docs/{RETROSPECTIVE_V,SMOKE_TEST_V,PLAN_V0_,V0_*_RELEASE_SCOPE, AUDIT_,PLAN_ACTION_AUDIT,REMEDIATION_PROGRESS}*.md → docs/archive/v0-history/ README.md and CONTRIBUTING.md preserved in apps/web/ and veza-backend-api/. Note: The .gitignore rules preventing recurrence were already pushed in3a5c6e184and remain in place — this commit does not modify .gitignore. Refs: AUDIT_REPORT.md §11
184 lines
4.7 KiB
Markdown
184 lines
4.7 KiB
Markdown
# PR7b — Finalisation P2 (Resilience & Performance)
|
|
|
|
**Date**: 2025-01-27
|
|
**Status**: ✅ **COMPLÉTÉ** - Tous les items P2 sont maintenant à 100%
|
|
|
|
---
|
|
|
|
## Items Corrigés
|
|
|
|
### ✅ MOD-P2-003: AppError Partout
|
|
**Status**: ✅ **COMPLÉTÉ** (100%)
|
|
|
|
**Fichiers modifiés**:
|
|
- `internal/core/track/handler.go`
|
|
- Converti toutes les occurrences de `gin.H{"error":...}` vers `respondWithError`
|
|
- **38 occurrences converties** dans les fonctions suivantes:
|
|
- `UpdateTracksBatch`
|
|
- `GetTrackLikesCount`
|
|
- `GetUserLikedTracks`
|
|
- `SearchTracks`
|
|
- `DownloadTrack`
|
|
- `CreateShare`
|
|
- `GetSharedTrack`
|
|
- `RevokeShare`
|
|
- `HandleStreamCallback`
|
|
- `GetTrackStats`
|
|
- `GetTrackHistory`
|
|
|
|
**Validation**:
|
|
```bash
|
|
grep -c 'gin\.H{"error":' internal/core/track/handler.go
|
|
# ✅ 0 occurrences restantes
|
|
|
|
go build ./internal/core/track
|
|
# ✅ Succès
|
|
```
|
|
|
|
---
|
|
|
|
### ✅ MOD-P2-007: Circuit Breakers
|
|
**Status**: ✅ **COMPLÉTÉ**
|
|
|
|
**Fichiers modifiés**:
|
|
1. `internal/services/circuit_breaker.go` (nouveau)
|
|
- Wrapper `CircuitBreakerHTTPClient` avec `github.com/sony/gobreaker`
|
|
- Configuration: 5 échecs consécutifs → circuit ouvert, 30s timeout, 60s interval
|
|
- Logging des changements d'état
|
|
|
|
2. `internal/services/stream_service.go`
|
|
- Intégration circuit breaker dans `StartProcessing`
|
|
- Utilise `circuitBreaker.DoWithContext()` au lieu de `client.Do()`
|
|
|
|
3. `internal/services/oauth_service.go`
|
|
- Intégration circuit breaker dans `getUserInfo`
|
|
- Utilise `circuitBreaker.Do()` au lieu de `client.Do()`
|
|
|
|
**Dépendance ajoutée**:
|
|
- `github.com/sony/gobreaker v1.0.0`
|
|
|
|
**Validation**:
|
|
```bash
|
|
go build ./internal/services
|
|
# ✅ Succès
|
|
|
|
go test ./internal/services -v -count=1
|
|
# ✅ Tests passent
|
|
```
|
|
|
|
---
|
|
|
|
### ✅ MOD-P2-008: File I/O Asynchrone
|
|
**Status**: ✅ **COMPLÉTÉ**
|
|
|
|
**Fichiers modifiés**:
|
|
- `internal/core/track/service.go`
|
|
- `UploadTrack`: File I/O rendu asynchrone avec goroutine
|
|
- Utilise channel pour gestion erreurs asynchrone
|
|
- Timeout de 5 minutes pour très gros fichiers
|
|
- Gestion cancellation via contexte
|
|
|
|
**Changements**:
|
|
- `io.Copy` exécuté dans une goroutine
|
|
- Channel `copyResult` pour récupérer résultat
|
|
- `select` avec timeout et contexte pour gestion asynchrone
|
|
|
|
**Validation**:
|
|
```bash
|
|
go build ./internal/core/track
|
|
# ✅ Succès
|
|
```
|
|
|
|
---
|
|
|
|
## Fichiers Modifiés (Résumé)
|
|
|
|
1. `internal/core/track/handler.go` - Conversion AppError (38 occurrences)
|
|
2. `internal/services/circuit_breaker.go` (nouveau) - Wrapper circuit breaker
|
|
3. `internal/services/stream_service.go` - Intégration circuit breaker
|
|
4. `internal/services/oauth_service.go` - Intégration circuit breaker
|
|
5. `internal/core/track/service.go` - File I/O asynchrone
|
|
6. `go.mod` - Ajout dépendance `github.com/sony/gobreaker`
|
|
|
|
---
|
|
|
|
## Commandes de Validation
|
|
|
|
### Build
|
|
```bash
|
|
go build ./internal/core/track
|
|
# ✅ Succès
|
|
|
|
go build ./internal/services
|
|
# ✅ Succès
|
|
|
|
go build ./cmd/api/main.go
|
|
# ✅ Succès
|
|
```
|
|
|
|
### Tests
|
|
```bash
|
|
go test ./internal/core/track -v -count=1 -short
|
|
# ✅ Tests passent
|
|
|
|
go test ./internal/services -v -count=1 -short
|
|
# ✅ Tests passent
|
|
```
|
|
|
|
### Vérification AppError
|
|
```bash
|
|
grep -c 'gin\.H{"error":' internal/core/track/handler.go
|
|
# ✅ 0 occurrences (toutes converties)
|
|
```
|
|
|
|
---
|
|
|
|
## État Final P2
|
|
|
|
| ID | Item | Status |
|
|
|----|------|--------|
|
|
| MOD-P2-004 | DB pool metrics | ✅ |
|
|
| MOD-P2-010 | Coverage CI | ✅ |
|
|
| MOD-P2-005 | Security headers middleware | ✅ |
|
|
| MOD-P2-002 | 2 entrypoints -> doc | ✅ |
|
|
| MOD-P2-001 | TODO audit -> doc | ✅ |
|
|
| MOD-P2-009 | Plan versioning API | ✅ |
|
|
| MOD-P2-006 | Retry HTTP externes | ✅ |
|
|
| MOD-P2-003 | AppError partout | ✅ **COMPLÉTÉ** |
|
|
| MOD-P2-007 | Circuit breakers | ✅ **COMPLÉTÉ** |
|
|
| MOD-P2-008 | File I/O asynchrone | ✅ **COMPLÉTÉ** |
|
|
|
|
**P2: 10/10 items corrigés (100%)** ✅
|
|
|
|
---
|
|
|
|
## Risques / Limitations
|
|
|
|
1. **Circuit Breaker**:
|
|
- Circuit s'ouvre après 5 échecs consécutifs
|
|
- Peut rejeter des requêtes légitimes si service externe lent
|
|
- **Mitigation**: Timeout de 30s avant half-open, logging des changements d'état
|
|
|
|
2. **File I/O Asynchrone**:
|
|
- Timeout de 5 minutes peut être insuffisant pour très gros fichiers (>1GB)
|
|
- **Mitigation**: Timeout configurable, peut être ajusté selon besoins
|
|
|
|
3. **AppError Conversion**:
|
|
- Toutes les occurrences converties dans `handler.go`
|
|
- Autres handlers peuvent encore utiliser `gin.H{"error":...}`
|
|
- **Mitigation**: Conversion progressive dans autres handlers si nécessaire
|
|
|
|
---
|
|
|
|
## Prochaines Étapes
|
|
|
|
- ✅ **P2 complété à 100%**
|
|
- 🎯 **Tous les items P0, P1, P2, P3 sont maintenant complétés**
|
|
|
|
---
|
|
|
|
**Statut Final**: ✅ **READY FOR REVIEW - P2 COMPLÉTÉ À 100%**
|
|
|
|
**Effort**: ~8h (comme estimé dans audit)
|
|
|
|
**Breaking Changes**: Aucun
|