senke/veza
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
veza/tests/e2e/SKIPPED_TESTS.md
senke 645fd23e22 test(e2e): skip 4 pre-existing @critical flakes with root cause + tickets — task #36 
All four tests were consistently failing (4/4 pre-push runs, not
intermittent) since commit 3640aec71 (2026-04-08, console.log →
expect conversion). The assertion-conversion landed without
verifying every new expect() against the current UI. SKIP_E2E=1
has masked them since the v1.0.6.2 hotfix.

Root cause investigation (4h timebox, 2026-04-18): actual cause
identified for each, fixes scoped in follow-up tasks. Not a race
condition / flake in the traditional sense — 3 of 4 are UI-drift
(selectors assume pre-v1.0.7 DOM shape), the 4th is a timing race
on expanded-player overlay that the inline comment documents
alongside the fix pattern (copy test 326's open-and-wait sequence).

Skip decisions made explicit rather than relying on SKIP_E2E=1:
  * Each test.skip carries the full forensic note as an inline
    comment — grep-able, code-review-able, impossible to lose.
  * tests/e2e/SKIPPED_TESTS.md indexes the four with tracking
    tickets (v107-e2e-01 through -04) and the unskip procedure.
  * SKIP_E2E=1 stays as the env-var bypass but is no longer
    required for the normal pre-push path — once this commit
    lands, next pre-push runs the @critical suite with these four
    skipped and the rest executing.

No v1.0.7 surface code touched. The four broken tests never
exercised marketplace / hyperswitch / stripe paths — they're all
player UI (3) and upload trigger (1), and v1.0.7 A-E commits all
land strictly in the money-movement surface.

Tracking tickets (#47-#50) include the fix hint for each, scoped
post-v1.0.7. SKIPPED_TESTS.md lists the unskip procedure: read the
inline note, implement the fix, run 100 local iterations green
before re-enabling.

This unblocks the v1.0.7-rc1 tag — the BLOCKER criterion
(investigation + PR-in-review before start of item F) is
satisfied: investigation done, root cause documented per test,
tickets opened with concrete fix hints.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-04-18 03:25:11 +02:00

2.7 KiB
Raw Blame History

Currently skipped @critical E2E tests

Tests in this list are marked test.skip(...) with a detailed inline comment above each test.skip. This file is the index so a reviewer or future maintainer can see the skip decisions at a glance without grepping.

Skipping a @critical test is a deliberate escape hatch, not a norm. Each entry below carries the root cause, the date the skip was introduced, and the tracking task ID. If the list grows past ~5 entries, that's a signal the E2E baseline is eroding and a maintenance pass is overdue.

v1.0.7 skips (task #36)

All four were consistently failing (4/4 pre-push runs, not intermittent flakes) since commit 7338a9a63 (2026-04-08, test(e2e): convert all remaining 298 console.log to real expect()). The assertion-conversion landed without verifying every new expect() against the current UI, so the broken tests slipped in and were masked by SKIP_E2E=1 during the v1.0.7 sprint.

Root-cause investigation timeboxed at 4h on 2026-04-18. Outcome: causes identified, fixes scoped, skip + tickets instead of in-line patch to keep the v1.0.7 tag scope tight.

File:line Test Root cause Ticket
03-player.spec.ts:9 01. Clic sur play lance la lecture d'un track Regex ^Lire matches the bulk-play label, not the single-track play button. Fix: target TrackCard/TrackListRow play button directly. v107-e2e-01
03-player.spec.ts:262 Cycle repeat off -> track -> playlist -> off Repeat button exists in two components (PlayerControls.tsx EN, RepeatShuffleButtons.tsx FR). Test finds EN button, asserts FR text → fail. Fix: assert on aria-pressed + count indicator, not free-text. v107-e2e-02
03-player.spec.ts:299 Controle vitesse de lecture — changement visible Test clicks Track info to open expanded player but doesn't wait for overlay before querying speed control. Fix: replicate the open-and-wait from test 326. v107-e2e-03
04-tracks.spec.ts:207 09. Upload accessible pour un createur via la bibliotheque Upload trigger regex doesn't match current /library UI — likely renamed or CloudUploadModal single-source-of-truth work (CHANGELOG-parked P2) changed the entry point. Fix: add data-testid="library-upload-cta" + target by testid. v107-e2e-04

How to unskip

  1. Read the inline comment above the test.skip for the full investigation notes.
  2. Implement the fix suggested.
  3. Run npx playwright test --grep "<test name>" --repeat-each 100 locally. 100/100 green before re-enabling.
  4. Remove the .skip and the eslint-disable comment. Keep the tests/e2e/SKIPPED_TESTS.md entry in a "fixed" section for a release or two so the history is traceable.